[WIP] refactor: switch to hex formatting #2843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2843/docs/iroh/ Last updated: 2024-11-29T15:59:28Z |
Contributor
Author
|
Greaaat.. labels can only be 63 bytes in local swarm discovery/dns land, meaning hex encoding won't fit.... 😭 |
Contributor
Yeah, that is the reason that pkarr uses zbase32. |
dignifiedquire
changed the title
dignifiedquire
force-pushed
the
refactor-switch-to-hex
branch
from
b6e22c9 to
c3742c5
Compare
Contributor
Author
|
closing in favor of #3042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches formatting to hex in all cases, except for tickets to preserve stability.
Depends on
Closes #2841
Breaking Changes
TODO