docs: Add nonce to chat messages to prevent deduplication of identica… #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
reviewed
Apr 29, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Thank you so much for the PR.
I'd appreciate if you could address the PR comments. After those are addressed, I'm fairly confident it's ready to merge.
| /// unique, so two identical chat messages are still delivered. | ||
| Message { | ||
| text: String, | ||
| nonce: u32, |
Member
There was a problem hiding this comment.
This is good! Can you make it a [u8; 16] though, just to make it borderline practically impossible for colliding nonces for the price of just a couple more bytes to send?
Suggested change
| nonce: u32, | |
| nonce: [u8; 16], |
| AboutMe { name: String }, | ||
| Message { text: String }, | ||
| AboutMe { | ||
| name: String, |
Member
There was a problem hiding this comment.
This message probably also needs a nonce, since when a new peer joins, you'd want to send yet another AboutMe message with your current username, but that'd currently fail sending.
Suggested change
| name: String, | |
| name: String, | |
| nonce: [u8; 16], |
Member
|
Fixes #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l messages
Description
Simply add a nonce field to the chat message to ensure duplicate messages are still delivered
Breaking Changes
N/A
Notes & open questions
Discussion in #iroh-gossip in Discord
Change checklist