-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add unix socket support #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clippy got a bump late last night :/ |
Thanks. Looks good on first glance. |
src/main.rs
Outdated
tracing::info!("derp url is {:?}", ticket.node_addr().relay_url); | ||
|
||
// handle a new incoming connection on the magic endpoint | ||
async fn handle_magic_accept( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove magic terminology from this, since we no longer refer to the endpoint as a magic endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pass through, and removed references to magic terminology
1/ hope matches matches what you were thinking?
2/ hopefully it's not overloading this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been thinking magicpipe would be a better name than dumbpipe for this utility though. It really feels like magic!
Very nice. Many of the code changes are just to make clippy happy and generic DRY. The code itself is nicely isolated. I don't see why we wouldn't merge this. One thing: it would be nice to have instructions how to test this locally. I just want to give it a very basic manual smoke test. |
# Conflicts: # src/main.rs
I can't for the life of me work out how CI is using clippy, I can't see these locally :) It might just take a few pushes to catch them all 🙏 |
I've updated the README to document the new commands. This is a quick screencast I posted to the discord running a smoke test: dumbpipe-unix.mp4 |
Hoping that last push will address the flakiness 🤞 |
Looks like a flake in |
Yup seems to have flaked. @rklaehn Can I ask you to do a one over on this. |
Anything I can do to help this one get over the line? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about dropping the ball on this a bit. I was traveling a lot.
The code seems to be pretty well separated, doesn't add any additional deps, so works for me.
Not so sure about the zellij example as an example, maybe we can come up with something more lightweight. But that can happen in a subsequent PR.
Thanks for the merge!
That makes sense. If you think of a lighter example, tag me in an issue and I can PR. I'll try and think of a lighter one too. |
This PR also removes magic terminology since we no longer refer to the endpoint as a magic endpoint.
Unit tests have been added. For a manual smoke test: