Fix data race b/c of lacking lock protection for "data" slice #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zensey
requested review from
soffokl,
Waldz,
tadaskay,
mdomasevicius,
Snawoot and
Guillembonet
as code owners
Zensey
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6017 +/- ##
==========================================
- Coverage 37.90% 37.84% -0.07%
==========================================
Files 371 371
Lines 20665 20667 +2
==========================================
- Hits 7833 7821 -12
- Misses 12054 12065 +11
- Partials 778 781 +3 ☔ View full report in Codecov by Sentry. |
Zensey
changed the title
Zensey
force-pushed
the
fix/datarace2
branch
4 times, most recently
from
1d3068f to
e759905
Compare
Signed-off-by: Anton Litvinov <[email protected]>
Zensey
force-pushed
the
fix/datarace2
branch
2 times, most recently
from
d9aca9f to
791d878
Compare
Signed-off-by: Anton Litvinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #5999 (comment)
To reproduce run
go run mage.go testThe test which reproduces the race: TestConsumerBalanceTracker_RecoverGrandTotalPromisedSettledIsBiggerThanPromissedNotOffChain