-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data races #6003
Fix data races #6003
Conversation
fabc311
to
833702d
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6003 +/- ##
==========================================
+ Coverage 37.90% 37.96% +0.05%
==========================================
Files 371 371
Lines 20665 20699 +34
==========================================
+ Hits 7833 7858 +25
- Misses 12054 12057 +3
- Partials 778 784 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zensey could you please add a test that proves the data race exists before the PR?
And after the PR fix, this race test starts to work and will protect us from appearing again in the future?
ccc77a4
to
de6316d
Compare
7e00d82
to
15770e0
Compare
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Signed-off-by: Anton Litvinov <[email protected]>
Resolves #5999