Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data races #6003

Merged
merged 13 commits into from
Apr 3, 2024
Merged

Fix data races #6003

merged 13 commits into from
Apr 3, 2024

Conversation

Zensey
Copy link
Contributor

@Zensey Zensey commented Mar 4, 2024

Resolves #5999

@Zensey Zensey self-assigned this Mar 4, 2024
@Zensey Zensey force-pushed the fix/datarace branch 11 times, most recently from fabc311 to 833702d Compare March 5, 2024 11:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.96%. Comparing base (4a517cd) to head (bb20c95).
Report is 28 commits behind head on master.

Files Patch % Lines
services/wireguard/service/service.go 40.00% 2 Missing and 1 partial ⚠️
core/service/pool.go 81.81% 1 Missing and 1 partial ⚠️
session/pingpong/hermes_channel.go 71.42% 1 Missing and 1 partial ⚠️
core/state/state.go 80.00% 1 Missing ⚠️
session/pingpong/hermes_channel_repository.go 92.85% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6003      +/-   ##
==========================================
+ Coverage   37.90%   37.96%   +0.05%     
==========================================
  Files         371      371              
  Lines       20665    20699      +34     
==========================================
+ Hits         7833     7858      +25     
- Misses      12054    12057       +3     
- Partials      778      784       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zensey Zensey changed the title [wip] Fix data race on sessionCleanup Fix data races Mar 5, 2024
Copy link
Member

@soffokl soffokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zensey could you please add a test that proves the data race exists before the PR?
And after the PR fix, this race test starts to work and will protect us from appearing again in the future?

@Zensey Zensey force-pushed the fix/datarace branch 7 times, most recently from ccc77a4 to de6316d Compare March 25, 2024 12:33
@Zensey Zensey force-pushed the fix/datarace branch 2 times, most recently from 7e00d82 to 15770e0 Compare March 27, 2024 07:58
@Zensey
Copy link
Contributor Author

Zensey commented Mar 29, 2024

@Zensey could you please add a test that proves the data race exists before the PR? And after the PR fix, this race test starts to work and will protect us from appearing again in the future?

@soffokl
done

@Zensey Zensey merged commit 6720107 into master Apr 3, 2024
20 checks passed
@Zensey Zensey deleted the fix/datarace branch April 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data races
3 participants