Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable s3 region lookup and ignore deletion error on Actions CI #5981

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

tzununbekov
Copy link
Contributor

This PR fixes errors discovered during test deployment:

  • AWS CLI fails to sync bucket contents because of the region lookup operation - disable lookup via additional env variable,
  • S3 bucket deletion does not run if previous steps fail - added post-run cleanup operation that should run always.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68056b2) 37.81% compared to head (2bd41a6) 37.80%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5981      +/-   ##
==========================================
- Coverage   37.81%   37.80%   -0.01%     
==========================================
  Files         371      371              
  Lines       20665    20665              
==========================================
- Hits         7814     7813       -1     
- Misses      12070    12071       +1     
  Partials      781      781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzununbekov tzununbekov merged commit 4e55638 into master Feb 21, 2024
19 checks passed
@tzununbekov tzununbekov deleted the ci-migration branch February 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants