Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the "tun" interface prefix for resolvconf call #5979

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Zensey
Copy link
Contributor

@Zensey Zensey commented Feb 20, 2024

The symptoms:
MystDark / node consumer doesn't work on Linux.
MystDark operates the node using --usermode flag.

But on establishing connection node (usermode) calls myst_superviser to do wg-up, which results into command:

script_type=up dev=myst0 foreign_option_1="dhcp-option DNS 10.182.3.1" /home/user/src/node/build/myst/config/update-resolv-conf

and it fails with

Failed to resolve interface "tun.myst0": No such device

The problem might not have been noticed if testing was carried out in VM / headless Linux, as it lacks resolvconf.
The problem only appears when OS has resolvconf.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d99042a) 37.78% compared to head (4e98ea3) 37.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5979      +/-   ##
==========================================
+ Coverage   37.78%   37.83%   +0.05%     
==========================================
  Files         371      371              
  Lines       20665    20665              
==========================================
+ Hits         7808     7819      +11     
+ Misses      12075    12065      -10     
+ Partials      782      781       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zensey Zensey merged commit 68056b2 into master Feb 21, 2024
18 checks passed
@Zensey Zensey deleted the fix/dvpn-linux branch February 21, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants