Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example Packets for COM_STMT_PREPARE Response and Suggestion on Payload Specification #593

Closed
wants to merge 3 commits into from

Conversation

cybergarage
Copy link

@cybergarage cybergarage commented Jan 31, 2025

Fixes for COM_STMT_PREPARE Response examples and a question with a proposed correction regarding the specification.

Suggestion on Payload Specification

  • The current payload specification reads the warning_count when packet_length > 12. However, both example packets have a packet_length of 12 (0x0C) and still include warning_count information. Should the specification be packet_length >= 12 instead, or is the condition unnecessary?
  • Note that MariaDB's payload specification does not have a conditional check on packet_length.

Fix Example Packets

  • The first example contained extraneous characters (|), which have been removed.

@cybergarage cybergarage marked this pull request as ready for review January 31, 2025 03:53
@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@daniyaalk
Copy link

daniyaalk commented Jan 31, 2025

@cybergarage I think those | characters have been added intentionally to illustrate the end of a MySQL Packet. Could probably be helpful if this was mentioned in a note.

@cybergarage
Copy link
Author

cybergarage commented Jan 31, 2025

@mysql-oca-bot I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=117373 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants