feat(php): manage map.jinja verification
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
myii
commented
Dec 22, 2020
myii
commented
- Prompted by:
- A start with splitting map.jinja and php works in focal (Ubuntu 20.04) saltstack-formulas/php-formula#214
- Add variables for Ubuntu 20.04 saltstack-formulas/php-formula#215
- [BUG] php.cli tries to write on wrong php.ini file in Ubuntu 20.04 LTS saltstack-formulas/php-formula#216
- [BUG] On Debian, does not work by default saltstack-formulas/php-formula#217
19 tasks
myii
added a commit
to saltstack-formulas/php-formula
that referenced
this pull request
Dec 22, 2020
* Automated using myii/ssf-formula#283
|
🎉 This PR is included in version 1.235.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
added a commit
that referenced
this pull request
Dec 23, 2020
`rubocop` already fixed during the previous PR (#283): * saltstack-formulas/php-formula#221
myii
pushed a commit
that referenced
this pull request
Dec 23, 2020
# [1.236.0](v1.235.0...v1.236.0) (2020-12-23) ### Features * **_mapdata:** use top-level `values` for `map.jinja` dump files ([705d9c3](705d9c3)) * **_mapdata_spec:** dump YAML back to string for better diffs ([02e2000](02e2000)) * **_mapdata.jinja:** use Black-inspired Jinja formatting ([0965c57](0965c57)) * **php:** add `rubocop` linter to `pre-commit` ([08b3b7e](08b3b7e)), closes [#283](#283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.