Akhil/notes milkdown editor - #247
Merged
Merged
Conversation
Notes previously used a ~27k-line custom "Notion-style" block editor that stored a bespoke ContainerNode tree as Note.content. Replace it with Milkdown Crepe, storing plain markdown. - Add NoteMarkdownEditor (Crepe): slash menu, toolbar, tables, code, images (onUpload -> existing Firebase handler), placeholder, class-based dark mode. - Rewire NotionEditor to markdown in/out: save, template apply, .md/.html export (HTML via marked), word count; all surrounding chrome preserved. - Make noteContentUtils self-contained and markdown-aware, with a hardened legacy tree->markdown converter (headings, ordered/unordered lists, links, images, code, GFM tables, inline formatting) for lazy migration of old notes. - Convert noteTemplates to markdown strings; document Note.content as markdown. - Delete components/ui/rich-editor entirely (69 files). - Add unit tests for the converter (14 cases). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.