Added DELIMITER support in jdbc script runner

[thekonz]

With this, you can create triggers and stored procedures.

[kzinnen]

Is anyone ever gonna take a look at this?
4 lines of code that have a huge impact.

[emacarron]

Sorry but I do not understand the change. Can you please explain it further?

[thekonz]

What does the current code do?
The script goes through the SQL line-by-line. It stores every line in the variable "command".
If the line ends with ;, the command gets executed.

How is this a problem?
If you create a trigger, you usually change the delimiter.

delimiter |

CREATE TRIGGER testref BEFORE INSERT ON test1
  FOR EACH ROW
  BEGIN
    INSERT INTO test2 SET a2 = NEW.a1;
    DELETE FROM test3 WHERE a3 = NEW.a1;
    UPDATE test4 SET b4 = b4 + 1 WHERE a4 = NEW.a1;
  END;
|

delimiter ;

Currently, the code executes the script as follows:

-- part 1
delimiter |

CREATE TRIGGER testref BEFORE INSERT ON test1
  FOR EACH ROW
  BEGIN
    INSERT INTO test2 SET a2 = NEW.a1;

-- part 2
    DELETE FROM test3 WHERE a3 = NEW.a1;

-- part 3
    UPDATE test4 SET b4 = b4 + 1 WHERE a4 = NEW.a1;

-- part 4
  END;

-- part 5
|

delimiter ;

This would cause a lot of errors and is not what you want the program to do.

What does this patch do?
The patch checks, if the line wants to change the delimiter and then sets the delimiter variable of the ScriptRunner to the new delimiter.

Remember the SQL from before? The ScriptRunner now executes the script as follows:

-- part 1
delimiter |

-- part 2
CREATE TRIGGER testref BEFORE INSERT ON test1
  FOR EACH ROW
  BEGIN
    INSERT INTO test2 SET a2 = NEW.a1;
    DELETE FROM test3 WHERE a3 = NEW.a1;
    UPDATE test4 SET b4 = b4 + 1 WHERE a4 = NEW.a1;
  END;
|

-- part 3
delimiter ;

Now you can create triggers and stored procedures with this.

[emacarron]

Clear as water :)

[thekonz]

thank you for merging

[emacarron]

A very good comment from #355.

[chb0github]

PR #355 doesn't really address the issue - if you use that change it means (at least for mysql) you have to create native client incompatible files. See this issue in migrations. I created a follow up issue to address this head on