Bug 2043832 - happy-eyeballs glean metrics for https rr#3
Draft
mxinden-bot wants to merge 1 commit into
Draft
Conversation
mxinden-bot
force-pushed
the
happy-https-rr-metrics
branch
from
fdaf105 to
100deb2
Compare
Adds happy_eyeballs_h3_discovery (was h3 advertised via Alt-Svc, an HTTPS record, both, or neither) and happy_eyeballs_https_rr_features (which features received HTTPS records carry: h3 ALPN, ECH, IP hints, against a total denominator), and drops the now redundant happy_eyeballs_https_record_available.
mxinden-bot
force-pushed
the
happy-https-rr-metrics
branch
from
100deb2 to
ca9a9d4
Compare
mxinden-bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
Upstream commit: https://webrtc.googlesource.com/src/+/978360941fb89b8459a72a2da0a91b1d05d0ca1a [M149] In SctpDataChannel use plain bool as safety flag. Original change's description: > In SctpDataChannel use plain bool as safety flag. > > SctpDataChannel can be destroyed on various threads and thus safety flag > couldn't be properly invalidated in the destructor. Instead of relying > on it when posting async send, rely on reference counting of the full > object > > Bug: chromium:504716948 > Change-Id: I1246fecac26d0761be006b069658d072183546bf > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/469980 > Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#47635} (cherry picked from commit 9b4ffb3281c02327968ed07389082fcb2dd77baa) Bug: chromium:514928086,chromium:504716948 Change-Id: I1246fecac26d0761be006b069658d072183546bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/474801 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/branch-heads/7827@{#3} Cr-Branched-From: d606bc991592fbf4dcbe85e9d05db5e501a5ad42-refs/heads/main@{#47595}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the Happy Eyeballs glean instrumentation (bug 2026606) with two labeled counters so we have field visibility into how Firefox discovers HTTP/3 and what the HTTPS DNS records we receive contain.
Metrics added (
netwerk/protocol/http/metrics.yaml)happy_eyeballs_h3_discovery(labeled_counter) — per run, crosses whetherAlt-Svcadvertised h3 with whether the HTTPS record advertised h3 in its ALPN set:none/altsvc_only/https_rr_only/both. Thealtsvc_onlybucket measures how often an origin supports h3 but only advertises it viaAlt-Svc, forcing the first connection to spend an extra round trip discovering h3 that a published HTTPS record would have avoided.happy_eyeballs_https_rr_features(labeled_counter) — which bootstrapping features the HTTPS records carried (h3_alpn,ech,ipv4hint,ipv6hint), unioned across all HTTPS records received for the connection, against atotaldenominator. ECH and the address hints can only be delivered ahead of the first connection via the DNS record.Drops the now-redundant
happy_eyeballs_https_record_available, whose available/unavailable split is derivable from the two new metrics.Wiring (
happy_eyeballs_glue/src/{lib,metrics}.rs)The glue passes the Alt-Svc list and the received HTTPS records to
metrics.rs, where all accounting (including the Alt-Svc h3 determination) lives. Counters are emitted inMetrics::drop.Notes
./mach build binaries+./mach lintpass.🤖 Generated with Claude Code
Generated by Claude Code