Fix: Mario correctly kicks still Koopa shells when boosting #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when you were boosting (holding shift) and ran into a still Koopa shell, Mario would die instead of kicking the shell. This commit refactors the `_onCollisionWithMob` method in `entities/Mario.py` to: - Ensure that kicking a still Koopa shell is prioritized over Mario dying if the conditions for a kick are met (side collision with a live, non-active, non-bouncing Koopa). - The Koopa shell now becomes `bouncing` and is kicked in the appropriate direction. - A small nudge is given to the kicked shell to help prevent immediate re-collision with a fast-moving Mario. - Additionally, I adjusted the logic for stomping an already still Koopa shell to make it start bouncing, aligning with common platformer mechanics.
Three new levels have been added to the game: - Level1-3.json - Level1-4.json - Level1-5.json These levels introduce varied designs, platforming challenges, and enemy placements. The game's menu system dynamically loads levels from the 'levels' directory, so these new levels will be available for selection automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when you were boosting (holding shift) and ran into a still Koopa shell, Mario would die instead of kicking the shell.
This commit refactors the
_onCollisionWithMobmethod inentities/Mario.pyto:bouncingand is kicked in the appropriate direction.