Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build the JupyterLab extension by default #1233

Merged
merged 2 commits into from
May 5, 2024
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented May 5, 2024

Closes #1210

Copy link

github-actions bot commented May 5, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/jupytext.git@no_extension_by_default

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the no_extension_by_default branch from eb65063 to 407b43e Compare May 5, 2024 19:06
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (ef4a2b7) to head (407b43e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          29       29           
  Lines        4464     4464           
=======================================
  Hits         4364     4364           
  Misses        100      100           
Flag Coverage Δ
external 75.17% <ø> (ø)
functional 88.51% <ø> (ø)
integration 77.28% <ø> (ø)
unit 66.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit c37f3e0 into main May 5, 2024
3 checks passed
@mwouts mwouts deleted the no_extension_by_default branch May 5, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Jupytext pre-commit hook fails to install when node is not available
1 participant