Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement require_hash in the get method of Jupytext's content manager #1202

Open
wants to merge 1 commit into
base: fix_notebook_corruption_with_jupyter_collaboration
Choose a base branch
from

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jan 9, 2024

Will close #1165

TODO:

  • Find out how to properly combine two hashes
  • Don't add a require_hash argument if the original contents manager does not have one
  • Add a test against jupyter_server==2.10.x

@mwouts mwouts marked this pull request as draft January 9, 2024 23:01
Copy link

github-actions bot commented Jan 9, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@implement_require_hash

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the implement_require_hash branch from 2d4854b to e019b91 Compare December 10, 2024 22:32
@mwouts mwouts changed the base branch from main to fix_notebook_corruption_with_jupyter_collaboration December 10, 2024 22:41
@mwouts mwouts marked this pull request as ready for review December 10, 2024 22:41
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (af4a8eb) to head (e019b91).

Files with missing lines Patch % Lines
src/jupytext/contentsmanager.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           fix_notebook_corruption_with_jupyter_collaboration    #1202      +/-   ##
======================================================================================
- Coverage                                               97.03%   95.43%   -1.60%     
======================================================================================
  Files                                                      29       29              
  Lines                                                    4479     4493      +14     
======================================================================================
- Hits                                                     4346     4288      -58     
- Misses                                                    133      205      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with jupyter_server 2.11.0
1 participant