Allow use of proxy when storing uploads to S3#11
Open
petemichel77 wants to merge 2 commits intomuzix:masterfrom
Open
Allow use of proxy when storing uploads to S3#11petemichel77 wants to merge 2 commits intomuzix:masterfrom
petemichel77 wants to merge 2 commits intomuzix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is common practice to isolate servers in a private network for security reasons. When doing so, it is necessary to communicate with the public internet through a proxy. This pull request allows a proxy url to be set so that communication with S3 can occur through the AWS SDK. This implementation uses the recommended way to use a proxy from the AWS documentation (http://docs.aws.amazon.com/AWSJavaScriptSDK/guide/node-configuring.html)
