Skip to content

fix: preview not working on android #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: preview not working on android #1131

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d9e5422
fix: preview not working on android
SputNikPlop Dec 16, 2023
2df9acc
fix: revert
SputNikPlop Dec 16, 2023
2a9efdc
fix: patch
SputNikPlop Dec 16, 2023
2b9d2ff
Merge branch 'main' into preview
SputNikPlop Dec 26, 2023
e9f21a1
Merge branch 'main' into preview
SputNikPlop Dec 26, 2023
12ddeea
Merge branch 'main' into preview
SputNikPlop Dec 27, 2023
31a5ead
Merge branch 'main' into preview
SputNikPlop Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/components/stream_preview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ class _StreamPreviewState extends State<StreamPreview> {
})
..setNavigationDelegate(NavigationDelegate(
onPageFinished: (url) async {


String? x = await _controller.currentUrl();
Copy link
Contributor

@kevmo314 kevmo314 Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually do?

Copy link
Collaborator Author

@SputNikPlop SputNikPlop Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just testing things, this is the point where I got stuck.

print('================================================================================================================================================================');
print(x);
if(x?.contains("controls=false")??false){
x = x?.replaceAll("controls=false","controls=true");
print(x);
_controller.loadRequest(Uri.parse(x??""));
}
await _controller.runJavaScript(
await rootBundle.loadString('assets/twitch-tunnel.js'));
// wait a second for twitch to catch up.
Expand Down Expand Up @@ -159,7 +169,7 @@ class _StreamPreviewState extends State<StreamPreview> {
),
),
)
else if (_playerState == "Playing")
else if (_playerState == "Playing"&&Platform.isIOS)
Positioned.fill(
child: GestureDetector(
onTap: () {
Expand Down