Skip to content

Make vertical turns available #28173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2025
Merged

Conversation

rettinghaus
Copy link
Contributor

@rettinghaus rettinghaus commented May 28, 2025

This makes the vertical turn glyphs and the Haydn ornament available in the extended ornaments palette including playback.

New turns available

The Haydn ornament is being played back correctly.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 28, 2025
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 28, 2025

Why not adding ornamentHaydn to the palettes too?

You'd need to make the names of these new ornaments translatable

muse::TranslatableString::untranslatable("Haydn ornament"),

muse::TranslatableString::untranslatable("Turn up"),
muse::TranslatableString::untranslatable("Inverted turn up"),

and add them to https://github.com/musescore/MuseScore/blob/88e39b7c51fcc8bdea1c15e6c49c74f59a026ada/tools/fonttools/smufl2sym-in-trans.json

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 28, 2025
@rettinghaus
Copy link
Contributor Author

I think the Haydn ornament is barely used, so I left it out intentionally. But I let @its-not-nice decide.

@its-not-nice
Copy link
Contributor

@rettinghaus There'd be no harm in having it in the 'More' section, I think!

@cbjeukendrup cbjeukendrup requested a review from its-not-nice May 29, 2025 13:18
@cbjeukendrup cbjeukendrup merged commit a00716b into musescore:master Jun 7, 2025
12 checks passed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 7, 2025
@rettinghaus rettinghaus deleted the verticalTurn branch June 7, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants