Refactor ComputeAndSetWaste()

murchandamus · Sep 13, 2023 · 18ca5c6 · 18ca5c6
1 parent f18f9ef
commit 18ca5c6
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp
@@ -500,13 +500,8 @@ void SelectionResult::SetBumpFeeDiscount(const CAmount discount)
 
 void SelectionResult::ComputeAndSetWaste(const CAmount min_viable_change, const CAmount change_cost, const CAmount change_fee)
 {
-    const CAmount change = GetChange(min_viable_change, change_fee);
-
-    if (change > 0) {
-        m_waste = GetSelectionWaste(change_cost, m_target, m_use_effective);
-    } else {
-        m_waste = GetSelectionWaste(0, m_target, m_use_effective);
-    }
+    bool makes_change = (0 != GetChange(min_viable_change, change_fee));
+    m_waste = GetSelectionWaste(makes_change ? change_cost : 0, m_target, m_use_effective);
 }
 
 CAmount SelectionResult::GetWaste() const