Skip to content

Develop #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Develop #16

wants to merge 10 commits into from

Conversation

@murasaqi
Copy link
Owner

No description provided.

torinos-yt and others added 8 commits January 28, 2025 15:01
@torinos-yt
syncClipのlistをcashする
37838f5
@torinos-yt
ラムダ式の変数キャプチャを回避
910bbd5
@torinos-yt
tcFormatの構築がフレームごとに走らないように
454d309
@torinos-yt
クリップ名の取得をinitで行うように変更
4f9b301
@torinos-yt
コード整理
adc728b
@murasaqi
Merge pull request #15 from murasaqi/fix/avoid-gcalloc
f98c9c4 
TImeline再生中のGC.Allocを低減
@murasaqi
WIP
6355959
@murasaqi @claude
feat: OSC制御機能の追加とMute All Clip機能の実装
eafee6a 
- MuteTimeMachineControlTrack/UnMuteTimeMachineControlTrackメソッドを修正
  - muteAllClipフィールドを制御するように変更
  - Unity Eventから呼び出し可能

- 新しいOSC制御機能を追加
  - /TimeMachine/Player/MuteAllClip: 全クリップをミュート
  - /TimeMachine/Player/UnMuteAllClip: 全クリップのミュートを解除
  - /TimeMachine/Player/UpdateClipsFinishStateByCurrentTime: 現在のタイムコードに基づいてクリップの完了状態を更新

- UpdateClipsFinishStateByCurrentTime()メソッドを追加
  - 過去のクリップ: isFinishOnStart/isFinishOnEnd = true
  - 現在実行中のクリップ: isFinishOnStart = true
  - 未来のクリップ: isFinishOnStart/isFinishOnEnd = false

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Aug 30, 2025 •
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

130 files out of 279 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

murasaqi and others added 2 commits September 1, 2025 00:28
@murasaqi @claude
fix: LTC Decoder参照がPlay Mode時にnullになる問題を修正
b46dbe9 
- EditorでのSerializedObject更新処理を改善
- ltcDecoderのSerializedPropertyを追加して適切に管理
- Start()メソッドにフォールバック処理を追加（nullの場合に自動探索）
- FindLtcDecoder()メソッドを実装して階層的に探索
- Auto Setup実行時のSerializedObject更新フローを最適化

これによりInspectorで設定したLTC Decoder参照がPlay Mode時にも確実に保持され、
LTC開始/停止時のMute/Unmute機能が正常に動作するようになりました。

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@murasaqi
LTC DecoderをRemove
29de3d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@murasaqi @torinos-yt