0.4.1 - #5
Merged
Merged
0.4.1#5
Conversation
<input type="file"> did nothing on tap: WebView needs a WebChromeClient that overrides onShowFileChooser and launches the system picker itself, and this app never set one. Added it alongside the existing capture launcher, using the same pending-callback pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Choose File and Attach a file buttons opened no picker at all on Android 13, so attaching to a note and restoring a backup were both dead ends. The WebView had no file-chooser handler, so every file input was inert.
Adds a WebChromeClient with onShowFileChooser plus an activity-result launcher that returns the picked files to the WebView, honoring the input's accept filter and handling a cancelled pick.
Tested on an Android 13 emulator: the picker opens and both attach and restore complete. Bumps to 0.4.1.