Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few minimal changes to get a somewhat working UI when using mumble on an iOS tablet. Basically this allows to rotate the screen and, split view etc.
The source code itself already included some specific iPad switches, which were not used as the info.plist file had only a
UIInterfaceOrientationPortrait
entry in theUISupportedInterfaceOrientations
array.A proper solution would be probably a proper SplitViewController etc. – but this was the first time after 5 years that I last looked at ObjectiveC source... :-)
Demo:
mumble-ipad.mp4
If you want to test this on your own device, and have no Apple Developer Account:
tld.your-domain.Mumble