Skip to content

editor_gui: Fix broken case-insensitive search #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

editor_gui: Fix broken case-insensitive search #686

merged 2 commits into from
Sep 19, 2025

Conversation

q8X
Copy link
Contributor

@q8X q8X commented Sep 19, 2025

previously the old method was making the search term lowercase leaving the map name in the original case

@q8X
Fix broken case insensitivee
1b42a0e 
previously the old method was making the search term lowercase leaving the map name in the original case
omar-o22
omar-o22 reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@omar-o22 omar-o22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use utf8.lower instead of string.lower.

Nico8340
Nico8340 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArranTuna ArranTuna merged commit 200d391 into multitheftauto:master Sep 19, 2025
1 check passed
@q8X q8X deleted the fix-Search-bar branch September 19, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@omar-o22 omar-o22 omar-o22 left review comments

@Nico8340 Nico8340 Nico8340 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@q8X @Nico8340 @omar-o22 @ArranTuna