Skip to content

editor_main: adding missing objects to list #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

q8X
Copy link
Contributor

@q8X q8X commented Feb 17, 2025

Fixes #601

@Dutchman101 Dutchman101 merged commit 03c0861 into multitheftauto:master Feb 17, 2025
1 check passed
@SpeedyFolf
Copy link
Contributor

I think you should've used the model names instead of custom names, just like every other object

@Fernando-A-Rocha
Copy link
Contributor

I think you should've used the model names instead of custom names, just like every other object

FYI in the client objects.xml list for the Object Browser, multiple keywords are available for all weapon models

<object model="346" name="Pistol" keywords="weapon,22,colt-45" />

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Feb 17, 2025

The names from getObjectNameFromModel which this PR modifies (it's serverside) are only used in serverside function assignID which the map editor calls when assigning a new name to an element placed using the Map Editor.

So this PR is fine tbh, the names used for weapons are more descriptive than their DFF names.

@q8X q8X deleted the update-object-names branch February 17, 2025 17:36
@q8X
Copy link
Contributor Author

q8X commented Feb 17, 2025

I think you should've used the model names instead of custom names, just like every other object

i used engineGetModelNameFromID to get the names of the missing objects, feel free to make PR to change these if u want

@q8X q8X restored the update-object-names branch March 19, 2025 21:04
@q8X q8X deleted the update-object-names branch March 19, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When adding weapon models as objects to a map, it doesn't save their name
4 participants