Fix model types to CHandlingManager #4068
Closed
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botder
reviewed
May 17, 2025
botder
previously approved these changes
May 26, 2025
botder
dismissed
their stale review
When I look over CHandlingManager.cpp, I see noexcept code that actually throws exceptions. The whole class is a manager for (static) global variables, basically static, but it pretends that it's not.
|
My system is broken, I'll fix it as soon as I fix it. |
|
I will take everything into account and create a new PR in the next 2-3 days (I have almost restored the system) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to change std::size_t to std::uint32_t.
I also changed GetHandilgID to static.