Add createBuilding for server #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TracerDS
suggested changes
Dec 22, 2024
| case CCLIENTBUILDING: | ||
| { | ||
| CClientBuilding* pBuilding = static_cast<CClientBuilding*>(pSource); | ||
| const unsigned short usCurrentModel = pBuilding->GetModel(); |
There was a problem hiding this comment.
auto or std::uint16_t
currentModel instead of usCurrentModel?
building instead of pBuilding?
| CClientBuilding* pBuilding = static_cast<CClientBuilding*>(pSource); | ||
| const unsigned short usCurrentModel = pBuilding->GetModel(); | ||
|
|
||
| if (usCurrentModel != usModel) |
There was a problem hiding this comment.
It's ok with one break at the end of the block.
TheNormalnij
commented
Dec 23, 2024
…te_building_server
|
can u update the branch because network module version has changed in (10b2e97) and reslove conflicts too |
TheNormalnij
force-pushed
the
TheNormalnij/create_building_server
branch
from
1377cb9 to
fbaff85
Compare
|
This is nice. Great job. It would be good to add building element type to map editor after this pr is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3716
Test resource: building_serverside.zip