Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OpenTargets as From/To database #30

Merged

Conversation

hlfernandez
Copy link
Contributor

The OpenTargets is now available and listed in the valid databases list (https://rest.uniprot.org/configure/idmapping/fields).

@multimeric
Copy link
Owner

This probably isn't clear from the file itself, but unipressed/id_mapping/types.py is auto-generated via codegen/id_mapping/generate.py. That needs to be re-run to ensure that there aren't any other databases that have been missed. I'm happy if you do that for this PR though.

@hlfernandez
Copy link
Contributor Author

Sure, I'll update the file using the generate.py script. Sorry for the inconvenience, I didn't notice that.

@hlfernandez hlfernandez force-pushed the hlfernandez-add-open-targets-db branch from eab9c93 to f8efb3e Compare May 8, 2024 15:25
@hlfernandez
Copy link
Contributor Author

@multimeric I have just run the generate.py script and updated the file. OpenTargets was the only addition but it was added in a different position so I have updated the file, amended the commit and made a push --force. Please, review the pull request and tell me if I should do anything else.

@multimeric
Copy link
Owner

That's good! It's better this way because it would pass the automated CI codegen build once I implement that. I'll fix the CI issues in a separate PR before I merge this.

@multimeric
Copy link
Owner

Okay, I've fixed the tests. Can you please pull from master and then this should be good to merge.

@hlfernandez hlfernandez force-pushed the hlfernandez-add-open-targets-db branch from f8efb3e to 87e263d Compare May 20, 2024 16:23
@hlfernandez
Copy link
Contributor Author

Okay, I've fixed the tests. Can you please pull from master and then this should be good to merge.

Done!

@multimeric multimeric merged commit 9769c2e into multimeric:master May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants