fix: handle context.Canceled in gemini backend to report "aborted" status#929
Open
kuishou68 wants to merge 1 commit intomultica-ai:mainfrom
Open
fix: handle context.Canceled in gemini backend to report "aborted" status#929kuishou68 wants to merge 1 commit intomultica-ai:mainfrom
kuishou68 wants to merge 1 commit intomultica-ai:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #928
Problem
The
geminiBackend.Executegoroutine inserver/pkg/agent/gemini.godoes not handlecontext.Canceled(user-initiated cancellation). When a task is stopped externally,runCtx.Err()returnscontext.Canceled, but the code only checks forcontext.DeadlineExceeded. As a result, user cancellations fall through to theelsebranch and are reported as"failed"instead of"aborted".The inline comment says "Distinguish context cancellation (timeout) from exit errors" but the implementation only partially fulfilled that intent.
Fix
Added a
context.Canceledbranch to mirror the behaviour already present inclaude.go:This ensures user-initiated cancellations are correctly reported as
"aborted"rather than"failed", consistent with all other backends.