fix(desktop): prevent false onboarding trigger on OTP login#1092
Open
fix(desktop): prevent false onboarding trigger on OTP login#1092
Conversation
…g workspaces When logging in via email/OTP, verifyCode sets `user` in the auth store before listWorkspaces + hydrateWorkspace complete. This causes AppContent to render DesktopShell with workspace=null, and OnboardingGate freezes that state — permanently showing the "create workspace" wizard. Three-part fix: - Add `workspaceHydrated` flag to workspace store (true once hydrateWorkspace has run, regardless of result) - Reorder AuthInitializer to hydrate workspace before flipping isLoading - Gate DesktopShell rendering on workspaceHydrated in AppContent
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyCode(email/OTP login) setsuserin auth store beforelistWorkspaces+hydrateWorkspacecomplete, causingOnboardingGateto freezehasWorkspace=falseworkspaceHydratedflag to workspace store soAppContentcan wait for definitive workspace state before renderingDesktopShellAuthInitializerto hydrate workspace before flippingisLoadingResolves MUL-888
Test plan
bootstrappingflag)pnpm typecheckpassespnpm testpasses (all 97 tests including login-page tests)