fix(daemon): normalize repo URL and clarify reposVersion intent#1090
Merged
fix(daemon): normalize repo URL and clarify reposVersion intent#1090
Conversation
- TrimSpace incoming repoURL in ensureRepoReady to prevent unnecessary server refreshes when CLI passes URLs with whitespace - Add comment on reposVersion field clarifying it is stored for future version-based skip optimization - Add concurrency safety comment on syncWorkspacesFromAPI skip logic - Add test for URL trimming fast-path behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up nit fixes from the review of #1085. Three small improvements:
TrimSpaceincomingrepoURLinensureRepoReadyso URLs with whitespace still hit the fast path instead of triggering unnecessary server refreshesreposVersionfield explaining it's stored for future version-based skip optimization (currently unused in comparison logic)syncWorkspacesFromAPImust not replace existingworkspaceStatepointers, sinceensureRepoReadyholdsws.repoRefreshMufrom the original pointerRelated Issue
Follow-up from #1085 review
Type of Change
Changes Made
server/internal/daemon/daemon.go: Addedstrings.TrimSpace(repoURL)atensureRepoReadyentry, added comment onreposVersionfield, added concurrency safety comment on workspace skip logicserver/internal/daemon/daemon_test.go: AddedTestEnsureRepoReadyTrimsURLtestHow to Test
AI Disclosure
AI tool used: Claude Code