-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W-16920599 | cbarakat fips test #249
base: main
Are you sure you want to change the base?
Conversation
@@ -84,6 +109,12 @@ public Object doResolveDependency(DependencyDescriptor descriptor, String beanNa | |||
*/ | |||
@Override | |||
protected <T> T doGetBean(String name, Class<T> requiredType, Object[] args, boolean typeCheckOnly) throws BeansException { | |||
if ("fips140-2".equals(System.getProperty("mule.security.model"))) { | |||
if (name.contains(DaoAuthenticationProvider.class.getName()) || DaoAuthenticationProvider.class.equals(requiredType)) { | |||
UserDetailsService userDetailsService = (UserDetailsService) super.getBean("userService"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find a way to parametrize this so users can set the name of the UserDetailsService bean
Thanks for the contribution! It looks like @sabecasissf @catalinbarakat is an internal user so signing the CLA is not required. However, we need to confirm this. |
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
Hi, thank you for your work. We understand that you want to merge your changes and move on from this issue, but we also want to maintain the safety, readability, and testability of our code. Because of this, we kindly ask that you confirm that you have fulfilled the prerequisites for each category of activity before merging your changes.
If the Pull Request has a dependency update:
For ALL the Releases:
NOTE: (applies only for Core-Connectors connectors and modules) The release process ends when you merge the pull request that updates the support branch to the new snapshot, please don't forget to do this.
Patch Version:
Minor Version:
Major Version: