Conversation
hannanelson
reviewed
Oct 23, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
reviewed
Oct 24, 2023
hannanelson
previously approved these changes
Oct 24, 2023
dhirsch1
reviewed
Nov 20, 2023
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 20, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
suggested changes
Nov 20, 2023
dhirsch1
left a comment
There was a problem hiding this comment.
In general, it would be better to specify which XML tag to use wen you are saying:
"add a line for...." or "add the following line" > "add the xxx tag"
When you say "add the following line," it is not clear which line you are referring to.
I may not have marked this until later in the doc.
Also, try to limit the use of admonitions.
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
previously approved these changes
Nov 20, 2023
dhirsch1
left a comment
There was a problem hiding this comment.
In general, it would be better to specify which XML tag to use wen you are saying:
"add a line for...." or "add the following line" > "add the xxx tag"
When you say "add the following line," it is not clear which line you are referring to.
I may not have marked this until later in the doc.
Also, try to limit the use of admonitions.
dhirsch1
reviewed
Nov 29, 2023
dhirsch1
reviewed
Nov 29, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
reviewed
Nov 29, 2023
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
dhirsch1
previously approved these changes
Nov 29, 2023
dhirsch1
previously approved these changes
Nov 29, 2023
egrave
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writer's Quality Checklist
Before merging your PR, did you: