FIX: Minor fixes introduced after scan was made using ruff check --fix . - #69
FIX: Minor fixes introduced after scan was made using ruff check --fix .#69Mionsz wants to merge 1 commit into
Conversation
mukul975
left a comment
There was a problem hiding this comment.
Thanks for the cleanup pass — the changes themselves are valid, but a few things need clarification before merge.
1. PR description is inaccurate — this is not print-statement removal
The description says 'Updated print statements to improve readability.' What the diff actually shows is F541 fixes — removing the f prefix from f-strings that contain no format variables (e.g. print(f"...no placeholders") → print("...no placeholders")). Plain ruff check --fix cannot remove print statements (that is rule T201, which is unsafe and off by default). Please update the PR description to accurately reflect what changed.
2. Verify F401 removals are safe
The diff removes from collections import defaultdict from skills/analyzing-campaign-attribution-evidence/scripts/process.py. Please confirm defaultdict is genuinely unused in that file — F401 auto-removal has known false positives when imports are used deeper in a class or in a branch not visible at the top of the file.
3. Confirm ruff version and exact command used
For a 479-file auto-fix PR, please add the ruff version (ruff --version) and the exact command to the PR description so the change is reproducible and reviewable.
Once those three are addressed this is straightforward to merge.
Refactor: Remove unused imports and clean up print statements across various scripts. Minor fixes introduced after scan was made using ruff check --fix .
json,sys, andcollectionsfrom multiple scripts to streamline code.