-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] DataGrid is in the lab #612
Conversation
pathname: '/components', | ||
subheader: '/components/data-grid', | ||
children: | ||
process.env.CONTEXT === 'production' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose? It seems like the objects are identical...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical until they are not :). We used to have different pages. I think that it's interesting to work on new features without releasing them to customers. But maybe it's no longer something that we need 🤔. I guess it's in the lab anyway. Actually, no, it's probably useful when features are highly unstable. It's not like in the core, some features take weeks to be built. Even for a lab state, that might not be good enough.
I think the grid will have less visibility in the lab, and I think it's less visible that it's an enterprise component part of a bigger package. |
|
I'm on the fence. I think I'd need to see it both ways and see what feels right. I can see pros and cons for both. |
No, answering the question asked:
|
I'm moving forward, I think that what's important is the semver part. There might be one point of confusion with having the data grid in the lab, it's not hosted in |
I thought the discussion was with respect to where it ends up when it leaves lab? |
@mbrookes Oh yeah sure, I was assuming that if we would be going in this direction, we could have a lab for Material-UI X too and move it there directly. Pros for going back to where it was:
Pros for having a different section for Material-UI X:
At the end of the day, I think that the main difference is about the message we communicate to developers. I think that sending the signal that all the components are designed to play well together allows us to differentiate again stitching together a bunch of open-source components. What would be the signal if we isolate Material-UI and Material-UI X? Is Data Grid Material-UI or Material-UI X? Is Date Picker Material-UI or Material-UI X? |
#568 (comment), same treatment that for the date picker.
Twin with mui/material-ui#23643