[pickers] Simplify the usePicker file structure
#16680
Draft
+1,117
−1,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
|
Deploy preview: https://deploy-preview-16680--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
clean-usePicker
branch
from
21b54f8 to
f908b18
Compare
flaviendelangle
force-pushed
the
clean-usePicker
branch
from
f908b18 to
3ca0384
Compare
flaviendelangle
force-pushed
the
clean-usePicker
branch
from
d7d67b3 to
6ed773f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length of the
usePickercode shrinked a lot during the alpha and I think the code is a lot cleaner if the logic is insideusePickerwith some utility hooks extrated.The typing especially is a lot simpler, without a lot less inheritance.
What's next?