Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Should we host MUI X on the main repository? #25

Closed
oliviertassinari opened this issue Jun 13, 2020 · 1 comment
Closed

[RFC] Should we host MUI X on the main repository? #25

oliviertassinari opened this issue Jun 13, 2020 · 1 comment
Labels
RFC Request For Comments

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 13, 2020

The idea to host the X line product in the main repository is growing in me. While we are going in this direction for the pickers: mui/material-ui#19706, I would like to continue the reflection for X. It's not obvious.

Pros

  • Better integration and coherence between the MIT and paid content: more code shared, more knowledge shared.
  • Avoid doing back and forth between the source and the documentation. From what I understand, the workflow will be as follow: make the change in this repository, wait for the next release schedule, (1-week frequency?) once the code is released, go to the main repository, update the documentation, wait for the next release schedule (1-week frequency). Live.
  • Share the same tooling, I have started to look at the tooling gap. I believe [core] Align the eslint configuration with the main repository #23 and [core] Align prettier tooling with main repository #24 are 5% of what's left to address. CircleCI, codesandbox-ci, bundle size tracking, test coverage, visual regression, Netlify deployment, cross-browser end to end tests (need to replace Jest with Mocha).
  • Else?

Cons

  • Less audience isolation. We risk paid content perverting and negatively influencing the MIT community.
  • Slower CI, which is the price for better integration. We can mitigate it by spending $ on better machines ($0/month so far) and introducing parallelism.
  • Else?

Can it scale?

Looking at larger projects, yes, it seems so

Note that if bug tracking is a concern, we can very well manage the concern independently to where the source is hosted: fullcalendar/fullcalendar-workspace#558.

Prior-arts

cc @mui-org/core

@oliviertassinari
Copy link
Member Author

We play it safe, two different repositories.

@oliviertassinari oliviertassinari changed the title [RFC] Should we host Material-UI X on the main repository? [RFC] Should we host MUI X on the main repository? May 19, 2022
@oliviertassinari oliviertassinari added the RFC Request For Comments label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

1 participant