Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Improve minimizing bundle docs #43781

Merged
merged 9 commits into from
Sep 17, 2024
Merged

[docs][material-ui] Improve minimizing bundle docs #43781

merged 9 commits into from
Sep 17, 2024

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Sep 15, 2024 •
edited
Loading

The legacy bundle was removed in v6. Should we just remove this section, or mention how to resolve to a different bundle? I have removed it.

Preview: https://deploy-preview-43781--material-ui.netlify.app/material-ui/guides/minimizing-bundle-size/

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Sep 15, 2024
@mui-bot
Copy link

mui-bot commented Sep 15, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2a3ac8d

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review September 15, 2024 06:12
@ZeeshanTamboli ZeeshanTamboli requested a review from a team September 15, 2024 06:31
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Remove "how to use custom bundles" section from minimizing bundle docs [docs][material-ui] Replace legacy with modern bundle in "how to use custom bundles" section from minimizing bundle docs Sep 16, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Replace legacy with modern bundle in "how to use custom bundles" section from minimizing bundle docs [docs][material-ui] Replace legacy with modern bundle in minimizing bundle docs Sep 16, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Replace legacy with modern bundle in minimizing bundle docs [docs][material-ui] Improve minimizing bundle docs Sep 16, 2024
@ZeeshanTamboli
Copy link
Member Author

@Janpot Ready for further review.

Janpot
Janpot approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. One suggestion added, at your own discretion.

docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md Show resolved Hide resolved
@ZeeshanTamboli ZeeshanTamboli merged commit 735d2d0 into mui:master Sep 17, 2024
22 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-legacy-bundle-from-minimizing-bundle-size-docs branch September 17, 2024 06:31
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Sep 18, 2024
Merged
1 task
@duy0000 duy0000 mentioned this pull request Oct 25, 2024
Open
This was referenced Oct 25, 2024
Open
Open
@bansikah22 bansikah22 mentioned this pull request Oct 26, 2024
Merged
@Eskedar21 Eskedar21 mentioned this pull request Oct 26, 2024
Open
@josetutis josetutis mentioned this pull request Oct 26, 2024
Open
@Hoang-Nguyen-Huy Hoang-Nguyen-Huy mentioned this pull request Oct 26, 2024
Merged
This was referenced Oct 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeeshanTamboli @mui-bot @Janpot @oliviertassinari