-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove HighlightedCode max-width #43731
Conversation
Netlify deploy previewhttps://deploy-preview-43731--material-ui.netlify.app/ Bundle size report |
This was needed to fix mobile overflow. I think to check that the initial cases are not broken. |
Do you remember which use-case this was fixing? I've been looking around at a bunch of code blocks and I can't figure out what this is trying to achieve. Seems to have initially been added in #27488. Opening a separate ticket for some other issues I noticed. |
The origin seems to be #20108. A reproduction of the bug: https://v4.mui.com/blog/march-2019-update/. Ok, it seems fine: https://deploy-preview-43731--material-ui.netlify.app/blog/march-2019-update/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not found any issue introduced by this PR.
What about doing the same modification to the MarkdownElement.tsx
file?
material-ui/packages/mui-docs/src/MarkdownElement/MarkdownElement.tsx
Lines 35 to 39 in bfe28ad
maxWidth: 'calc(100vw - 32px)', | |
maxHeight: '400px', | |
[lightTheme.breakpoints.up('md')]: { | |
maxWidth: 'calc(100vw - 32px - 16px)', | |
}, |
At least in screenshots that seems to fix a few more things: https://app.argos-ci.com/mui/material-ui/builds/32870/113602375 Can't find any regressions on pages that use it |
This messes up a bit the copy button positioning: https://app.argos-ci.com/mui/material-ui/builds/31842/107814670
Not sure why it's there. Removing to see if I can find something breaking. I can't find an instance of this component where this CSS can have an impact 🤔