-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Typography] Enforce responsive typography type checking in sx prop #42945
Open
Sergio16T
wants to merge
14
commits into
mui:master
Choose a base branch
from
Sergio16T:MUI-42918
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−7
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
91727e1
[material-ui][Typography] Enforce responsive typography type checking…
Sergio16T 3bab057
[material-ui][Typography][Alert-Title][Dialog-Content][Dialog-Title][…
Sergio16T 8c3e738
[material-ui][Typography][Alert-Title][Dialog-Content][Dialog-Title][…
Sergio16T 0554e34
[material-ui][Typography][Alert-Title][Dialog-Content][Dialog-Title][…
Sergio16T 8edaac1
[material-ui][Typography][Alert-Title][Dialog-Content][Dialog-Title][…
Sergio16T 6802737
[material-ui][Typography][Alert-Title][Dialog-Content][Dialog-Title][…
Sergio16T 03cd8a8
push changes
ZeeshanTamboli aa46c3a
prettier changes
ZeeshanTamboli 4a02324
ignore sx prop in proptypes
ZeeshanTamboli 4a2a15d
[material-ui][typography] added custom typography variant override su…
Sergio16T d672e7d
move typography variant overrides test to module augmentation test file
ZeeshanTamboli 49ddf76
Merge branch 'next' into MUI-42918
ZeeshanTamboli 267507c
Merge branch 'next' into MUI-42918
ZeeshanTamboli 556ce79
resolve conflict
ZeeshanTamboli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if we can eventually use custom typography variants if they are re-declared in
d.ts
files. E.g. will the code above throw an error with this overrides:Or in other words, will TS compiler be "okay" with
body 1
if we declare it beforehand?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @goodwin64! I believe adding custom typography variants is supported.
I added module override to unit test to confirm this and also locally tested adding the above code block in
typography.d.ts
Pushed up unit test update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome news! Thank you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sergio16T Thanks for the test. We handle TypeScript module augmentation tests separately because they apply globally and need isolated testing. For custom Typography variants, there's already a test file. I added this case there instead.
Edit: Even custom breakpoints are supported.