[전호영] 5장, 6장, 7장: 형식 맞추기, 객체와 자료 구조, 오류 처리 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoyeongJeon
requested review from
bbbang105,
choihooo,
codrin2,
karnelll,
nebulaBdj and
yeyounging
as code owners
bbbang105
approved these changes
Jul 2, 2025
6장/전호영.md
Outdated
7장/전호영.md
Outdated
5장/전호영.md
Outdated
Member
There was a problem hiding this comment.
저는 약간 생각이 다른 게, 공백이나 줄바꿈도 코드에서 중요한 부분을 차지한다고 생각합니다.
컨벤션을 지킨 코드와 안 지킨 코드는 가독성이 많이 차이나는 것 같아요. 보기에도 좀 불편하고 ...
하지만 코드 길이 등에 대해서는 나름 공감합니다. 결국 모든 것은 상황에 따라 하면 될 것 같아요!
Collaborator
Author
There was a problem hiding this comment.
저도 컨벤션을 지키는 것에 대해 공감합니다~!
여기 적었던 내용은 컨벤션 보단
- 공백은 어떤 기준으로 하라
- 코드 길이는 이 정도로 해라
이 기준 또는 어느 정도에 대한 생각이었습니다.
어떤 부분에선 "내 경험상 코드 길이는 30줄이 좋았으니 30줄이 클린 코드다~" 이런 식으로 적힌 듯 한 부분들이 있어 해당 부분에 대해선 공감이 안가더라구요.
choihooo
approved these changes
Jul 7, 2025
6장/전호영.md
Outdated
Collaborator
There was a problem hiding this comment.
저는 DTO를 여기서 처음 정확하게 알았습니다
Collaborator
Author
There was a problem hiding this comment.
경험상 swagger에 보이는 응답 형식(타입, 이름 etc)는 거의 다 dto 구조 입니다 ㅎㅎㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.