Return an interface instead of a struct #159
Conversation
| @@ -165,7 +165,7 @@ func peers2AddrInfo(peers []string) []peer.AddrInfo { | |||
| var infiniteResourceLimits = rcmgr.InfiniteLimits.ToPartialLimitConfig().System | |||
|
|
|||
| // ToOpts returns node and vpn options from a configuration | |||
| func (c Config) ToOpts(l *logger.Logger) ([]node.Option, []vpn.Option, error) { | |||
| func (c Config) ToOpts() ([]node.Option, []vpn.Option, error) { | |||
There was a problem hiding this comment.
the logger was not really being used in this function anywhere
Itxaka
force-pushed
the
logger_iface
branch
2 times, most recently
from
9f210fc
to
abfa7e4
Compare
Signed-off-by: Itxaka <[email protected]>
|
I'm quite against returning interfaces - I do believe structs are much better so the consumer actually can tie together without being bound to a specific interface that needs to be satisfied. Ideally the consumer should just take care of that bit. Why is this needed? |
mainly because you are bounded tto send the exact struct that this function needs. With an interface you can pass any object that implements that interface so in this case the caller can have its own logger implementation and pass that instead of forcing the caller to pass as struct. Thats the whole point of the interface thingie in golang no? |
No description provided.