fix: multiplicative backoff for shutdown #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always retry every two seconds, back off the shutdown attempt rate? Signed-off-by: Dave <[email protected]>
dave-gray101
changed the title
Signed-off-by: Dave <[email protected]>
mudler
reviewed
Sep 16, 2024
Signed-off-by: Dave Lee <[email protected]>
dave-gray101
added a commit
that referenced
this pull request
Sep 17, 2024
* fix(shutdown): do not shutdown immediately busy backends Signed-off-by: Ettore Di Giacinto <[email protected]> * chore(refactor): avoid duplicate functions Signed-off-by: Ettore Di Giacinto <[email protected]> * fix: multiplicative backoff for shutdown (#3547) * multiplicative backoff for shutdown Rather than always retry every two seconds, back off the shutdown attempt rate? Signed-off-by: Dave <[email protected]> * Update loader.go Signed-off-by: Dave <[email protected]> * add clamp of 2 minutes Signed-off-by: Dave Lee <[email protected]> --------- Signed-off-by: Dave <[email protected]> Signed-off-by: Dave Lee <[email protected]> --------- Signed-off-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Dave <[email protected]> Signed-off-by: Dave Lee <[email protected]> Co-authored-by: Dave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always retry every two seconds, back off the shutdown attempt rate?
Description
This PR fixes #3543
Notes for Reviewers
Suggesting this as a PR-to-PR since it may or may not be necessary. I don't think we need to go all the way to exponential backoff for this situation.