rebis-dev cargo fmt and Clippy #2831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one was a toughie: it turns out that using `ptr::align_of()`` was a bad idea, since the buffer in `Heap` itself is not aligned to `Heap::heap_cell_alignment()`, so `ptr::align_of()` would sometimes return lower values than expected. That made for an heisenbug: if the alignment of the heap happened to be 4, then the bug wouldn't trigger.
rebis-dev: Fix imports for benches
rebis-dev: Fix UB detected by miri in tests
|
Could you try cherry picking the commit from #2793 to fix CI? |
Without this `cargo clippy --fix` crashes.
bakaq
force-pushed
the
rebis_fmt_clippy
branch
from
c61b9cb to
31a56fd
Compare
|
Mh, macos has a segmentation fault, Edit: Its is wasm job that fails to compile not the normal nightly build. |
|
The single test failure is the one I mentioned in the OP. I've been able to get 1.77 to compile. |
|
The tests should start passing again with #2759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
cargo fmt(to make CI happy) and fixes the Clippy warnings (so that we can benefit from its advice without noise).The diff for
cargo fmtis quite big, so it may be better if you do this locally. Manually fixing the warnings wasn't trivial though.Notice that the test that failed here is also failing in the current
rebis-dev, so nothing regressed.