Conversation
Contributor
Author
|
The tests I’ve run have given me the results I expected. If I have introduced any new bugs, I’ll fix ’em when they become an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early this year we hacked a tool to output daily usage or a requester into the
new_optionsbranch (PR #3) by repurposing the month view, and have been running that in production for a while despite never actually accepting that PR and making a new one.There were some weird spots in the way the options interacted with each other and the output, so we refactored everything to clean it all up. In the meantime we also upgraded to IdP version 5, which convinced us to finally give up
on tracking which modules are known but not helpful and skipping over them silently.
Daily was really our best use case for the month view, but for arbitrary time periods instead of one month, so I left the option commented out for a while, but in the absence of a need, I’ve removed it.
SSO does not look like we thought it did in the logs, so I’m leaving that commented out in the options. As we get the latter sorted out I’ll fold the work into PR #4.