Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-packages] tree-sitter-c, tree-sitter-lua, tree-sitter-markdown, tree-sitter-query, tree-sitter-vim, tree-sitter-vimdoc #23499

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

calebabutler
Copy link

These packages are dependencies for newer versions of neovim. Currently neovim gives an error when opening *.lua, *.c, *.md, *.vim, and when opening vim documentation since the program lacks these dependencies.

Proof they are now dependencies here and here.

@calebabutler
Copy link
Author

#23261

@calebabutler
Copy link
Author

@Biswa96 neovim maintainer

@@ -93,4 +99,7 @@ package() {
DESTDIR="${pkgdir}" "${MINGW_PREFIX}"/bin/cmake.exe --install .

install -Dm644 "${srcdir}/${_realname}-${pkgver}/LICENSE.txt" "${pkgdir}${MINGW_PREFIX}/share/licenses/${_realname}/LICENSE.txt"

# Symlink tree-sitter grammars directory to nvim runtime path
ln -s "${MINGW_PREFIX}/lib/tree_sitter" "${pkgdir}${MINGW_PREFIX}/share/nvim/runtime/parser"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symlink won't work as you expect: https://www.msys2.org/docs/symlinks/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct; this cannot be the best solution as it inadvertently bundles the tree-sitter-* so files with neovim. I changed it so that the tree-sitter-* packages add to the neovim runtime path directly in their respective packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants