-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental feat (container app environments): [topology] add multiple container app environments #12
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, one comment on frontend env naming.
main.bicep
Outdated
module env_shipping_dronedelivery 'environment.bicep' = { | ||
name: 'env-shipping-dronedelivery' | ||
// Drone Delivery App Environment Frontend | ||
module env_shipping_dronedelivery_front 'environment.bicep' = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be more consistent with "frontend" "backend", instead of shortening to "front"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7569a43
to
8918e20
Compare
…onments (#15) * adds why multiple environments narrative * Apply PR Feedback: improving wording, fixing typos and other contribs. Co-authored-by: Catherine Bundy <[email protected]>
WHY
Having
Ingestion
service separated from the rest of the underling services using a Service Bus queue in middle, it allow us to have two clearly separated local container app environments divided into Front and Backend. This is feasible becauseIngestion
has no direct communication with the underlaying service or sharing compute resources at all. Additionally, this separation could enable a better network topology in the future.WHAT Changed?
HOW to Test?
Follow the
README
instructions and you should be able to go thought the validation section and execute all the steps successfully.