Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental feat (container app environments): [topology] add multiple container app environments #12

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Feb 22, 2022

WHY

Having Ingestion service separated from the rest of the underling services using a Service Bus queue in middle, it allow us to have two clearly separated local container app environments divided into Front and Backend. This is feasible because Ingestion has no direct communication with the underlaying service or sharing compute resources at all. Additionally, this separation could enable a better network topology in the future.

WHAT Changed?

  • add a second environment
  • modify diagram to depict the new topology
  • enhance narratives

HOW to Test?

Follow the README instructions and you should be able to go thought the validation section and execute all the steps successfully.

Copy link
Contributor

@hallihan hallihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one comment on frontend env naming.

main.bicep Outdated
module env_shipping_dronedelivery 'environment.bicep' = {
name: 'env-shipping-dronedelivery'
// Drone Delivery App Environment Frontend
module env_shipping_dronedelivery_front 'environment.bicep' = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be more consistent with "frontend" "backend", instead of shortening to "front"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea @hallihan

doen | addressed from 91937

…onments (#15)

* adds why multiple environments narrative

* Apply PR Feedback: improving wording, fixing typos and other contribs.

Co-authored-by: Catherine Bundy <[email protected]>
@ferantivero ferantivero changed the title feat (container app environments): [topology] add multiple container app environments experimental feat (container app environments): [topology] add multiple container app environments Feb 25, 2022
@ferantivero ferantivero marked this pull request as draft March 2, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants