arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree #393
Conversation
Signed-off-by: Paul Adam <[email protected]>
myryk31415
changed the title
myryk31415
force-pushed
the
wiko-chuppito
branch
from
863fccf to
f567834
Compare
There was a problem hiding this comment.
Few more small nits.
Also to note, I'd appreciate if you separate upstreamable and not-yet-upstreamable commits when you work on this. That is, keep addition of display and other nodes that rely on not-yet-upstream drivers as separate commits, and anything that could land upstream squash into a single "Add initial devicetree" commit. (bindings are separate commit that should be first, keep it as is)
I'd also appreciate if you can fill in a short blurb into the bindings/initial dt commit messages, see i.e. this series for an example.
When you're done I'd like to ask you to submit upstreamable part upstream, so I can backport it into our tree and not rebase forever, which would help with maintenance a lot. Of course we will still provide you with preliminary review comments based on what we expect upstream to think while you continue to work in this PR.
myryk31415
force-pushed
the
wiko-chuppito
branch
from
67e5ec9 to
7a6d80f
Compare
|
What about the WCN3620 module? You do need firmware for that but the drivers are in the kernel right? So it doesn't need an extra commit? |
With a few exceptions, only display panel is non-upstreamable. You can check upstream msm8916 devices for examples of what's "upstreamable" and git history of this repo for examples of something that we didn't/couldn't upstream yet. |
myryk31415
force-pushed
the
wiko-chuppito
branch
2 times, most recently
from
d6833d0 to
c36eab3
Compare
myryk31415
force-pushed
the
wiko-chuppito
branch
2 times, most recently
from
a0e2ab4 to
2f7234e
Compare
myryk31415
force-pushed
the
wiko-chuppito
branch
from
2f7234e to
d800853
Compare
|
Oh sorry the incorrect formating and notes I left, I'm gonna clean them up but right now I'm still struggling with the audio |
myryk31415
force-pushed
the
wiko-chuppito
branch
3 times, most recently
from
34a8455 to
450da3f
Compare
Signed-off-by: Paul Adam <[email protected]>
Signed-off-by: Paul Adam <[email protected]>
myryk31415
force-pushed
the
wiko-chuppito
branch
from
450da3f to
159cc41
Compare
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&button_backlight_default>; |
There was a problem hiding this comment.
| pinctrl-names = "default"; | |
| pinctrl-0 = <&button_backlight_default>; | |
| pinctrl-0 = <&button_backlight_default>; | |
| pinctrl-names = "default"; |
| // make sure gcc is probed with display disabled. | ||
| &gcc { | ||
| clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>; | ||
| }; |
There was a problem hiding this comment.
Is the display still disabled?
| status = "okay"; | ||
| port { |
There was a problem hiding this comment.
| status = "okay"; | |
| port { | |
| status = "okay"; | |
| port { |
| @@ -0,0 +1,402 @@ | |||
| // SPDX-License-Identifier: GPL-2.0-only | |||
There was a problem hiding this comment.
Add configs and use generate.sh in linux-panel-drivers instead of adding the driver manually.
This adds a devicetree for wiko-chuppito aka Wiko Pulp 4g with following features: