-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(shutdown): implement graceful shutdown for camera session #3650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add shutdown method to stop all outputs and release resources - Schedule shutdown with warning if it takes longer than expected
|
@EthanDM is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
mrousavy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR - seems like there were some issues with proper session shutdown on Fabric - I wonder why that wasn't a problem before on Paper. Maybe view caching/recycling?
Anyways - I left some review comments
Co-authored-by: Marc Rousavy <[email protected]>
- Remove unnecessary delegate assignments before removing outputs - Ensure completion block is called in all error scenarios during configuration
|
Thanks for the review @mrousavy, I addressed all of the comments and retested. Still no freezes during mount/unmount. Let me know if anything else is needed. |
What
Fix the navigation freeze on React Navigation/Fabric by shutting the camera session down deterministically when the view unmounts.
Changes
Tested on
Related issues