Skip to content

fix(ios): show progress for slow session actions and word the take-over pill neutrally - #2615

Open
mrmans0n wants to merge 1 commit into
mainfrom
nacho/ios-smoke-polish
Open

mrmans0n wants to merge 1 commit into
mainfrom
nacho/ios-smoke-polish

Conversation

@mrmans0n

Copy link
Copy Markdown
Owner

Fixes from the iOS smoke test.

  • Take-over pill: said "Another device is driving" even when nobody held the session. The phone only knows it can't drive, so it now reads "Take over to drive this session". The host's notWriter refusal, as the phone words it, now reads "Take over this session first."
  • Progress: Close Session, Archive Session, and Archive/Delete Worktree showed nothing while the host worked (delete took ~20 s). The transcript screen now shows a progress overlay and disables itself until the host answers.
  • Session Settings: long option descriptions stop at two lines.

Testing

  • iOS simulator build.
  • swift test --package-path Packages/AlasCore --filter RemoteWireCompatibilityTests (18 tests).

…er pill neutrally

The take-over pill and the host's notWriter refusal said another device was
driving even when nobody held the session; the phone only knows it can't drive.
Close, archive and delete now show a progress overlay until the host answers,
and long option descriptions in Session Settings stop at two lines.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T16:06:00.128801Z 5543495 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant