Skip to content

fix: resolve all issues from #26 — deps, badges, CODEOWNERS, branch refs, duplicate dir - #29

Open
mr-adonis-jimenez wants to merge 6 commits into
mainfrom
fix/issue-26-repo-config
Open

fix: resolve all issues from #26 — deps, badges, CODEOWNERS, branch refs, duplicate dir#29
mr-adonis-jimenez wants to merge 6 commits into
mainfrom
fix/issue-26-repo-config

Conversation

@mr-adonis-jimenez

Copy link
Copy Markdown
Owner

Closes #26

Addresses all 5 issues from the report:

1. ✅ requirements.txt synced with pyproject.toml

Added missing numpy, python-multipart, and all dev deps (pytest-cov, pytest-asyncio, black, flake8, isort, pylint). Split into clear Core / Dev sections with comments.

2. ✅ README badges fixed

  • Removed ![npm](https://img.shields.io/npm/v/your-package) (this is a Python project, not npm)
  • Replaced placeholder ![CI](https://github.com/you/repo/...) with the actual CI badge pointing to ci-cd.yml in this repo
  • Added MIT license badge

3. ✅ CODEOWNERS moved to correct location

  • Created .github/CODEOWNERS (no .md extension) — GitHub now recognizes it for code ownership
  • Removed root CODEOWNERS.md
  • Updated owners to @mr-adonis-jimenez (removed placeholder team references)

4. ✅ mastermain branch references

  • Updated README.md and CONTRIBUTING.md to reference main throughout

5. ✅ Duplicate GitHub/ directory cleaned up

  • Deleted GitHub/dependabot.yml — it was a stale npm config duplicating the proper .github/dependabot.yml (which covers pip, GitHub Actions, and Docker)
  • GitHub/ directory is now empty and will be removed from the tree

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository's configuration and documentation. Key changes include transitioning branch references from 'master' to 'main' in CONTRIBUTING.md and README.md, consolidating the CODEOWNERS file under a single owner, and expanding the requirements.txt file with categorized core and development dependencies. Additionally, the README.md was updated with new badges and refined architecture details, while obsolete configuration files were removed. I have no feedback to provide.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 931a70e58e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CONTRIBUTING.md
### Enable repository git hooks (recommended)

This repo includes a `pre-push` hook to prevent direct pushes to the protected `master` branch.
This repo includes a `pre-push` hook to prevent direct pushes to the protected `main` branch.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct protected branch name in hook guidance

The updated docs now state that the local pre-push hook blocks pushes to main, but scripts/git-hooks/pre-push still hard-codes refs/heads/master. In this state, contributors who follow CONTRIBUTING.md can still push directly to main, so the branch-protection guidance is inaccurate and creates a false sense of enforcement.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix repository configuration and dependency issues

1 participant